From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sun, 07 Feb 2016 08:48:47 GMT
Subject: Re: [PATCH v6 00/11] Fix icase grep on non-ascii
Message-ID: <CAPig+cSU9g28a7tnXJvoGJ4MkmnuWmcsy+vGUiY6L8+9v6iusg@mail.gmail.com>
In-Reply-To: <1454724190-14063-1-git-send-email-pclouds@gmail.com>

On Fri, Feb 5, 2016 at 9:02 PM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
> v6 fixes comments from Ramsay and Eric. Interdiff below. The only
> thing to add is, I decided not to replace !icase_non_ascii with
> icase_ascii_only. I went with spelling out "!icase || ascii_only". I
> think it expresses the intention better.

v6 appears to address all the comments raised in my v5 review. Thanks.