From: Eric Sunshine <sunshine@sunshineco.com>
Date: Tue, 26 Jun 2018 20:06:39 GMT
Subject: Re: [PATCH 14/29] t: drop subshell with missing &&-chain in favor of simpler construct
Message-ID: <CAPig+cSJe+bHK+P6_8Q7u_t65bFhVk9zEyQY7L_yVL7g0J-j3w@mail.gmail.com>
In-Reply-To: <xmqqsh59jqea.fsf@gitster-ct.c.googlers.com>

On Tue, Jun 26, 2018 at 3:31 PM Junio C Hamano <gitster@pobox.com> wrote:
> Eric Sunshine <sunshine@sunshineco.com> writes:
> > These tests employ a noisy subshell (with missing &&-chain) to feed
> > input into Git commands:
> >
> >     (echo a; echo b; echo c) | git some-command ...
> >
> > Drop the subshell in favor of a simple 'printf':
> >
> >     printf "%s\n" a b c | git some-command ...
>
> That's called test_write_lines, I think.

Yep, that's better. Thanks.