From: Eric Sunshine <sunshine@sunshineco.com>
Date: Wed, 29 Jul 2020 02:57:17 GMT
Subject: Re: [PATCH v5 33/39] Enable SHA-256 support by default
Message-ID: <CAPig+cSErEWAaDtpOBbWDuQd+6yN4UKmUvMjKpT6AAd+SwkyTw@mail.gmail.com>
In-Reply-To: <20200728233446.3066485-34-sandals@crustytoothpaste.net>

On Tue, Jul 28, 2020 at 7:36 PM brian m. carlson
<sandals@crustytoothpaste.net> wrote:
> Subject: Enable SHA-256 support by default

If you happen to re-roll, perhaps: s/Enable/enable/

> Now that the we have a complete SHA-256 implementation in Git, let's

Still wonky grammar here (mentioned previously): "Now that the we have..."

> enable it so people can use it.  Remove the ENABLE_SHA256 define
> constant everywhere it's used.  Add tests for initializing a repository
> with SHA-256.
>
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>