From: Eric Sunshine Date: Tue, 23 Jun 2020 21:24:34 GMT Subject: Re: [PATCH 1/2] revision: use repository from rev_info when parsing commits Message-ID: In-Reply-To: <20200623205659.14297-1-mforney@mforney.org> On Tue, Jun 23, 2020 at 5:02 PM Michael Forney wrote: > This is needed when repo_init_revisions() is called with a repository > that is not the_repository to ensure appropriate repository is used > in repo_parse_commit_internal(). If the wrong repository is used, > a fatal error is the commit-graph machinery occurs: s/is/in/ > fatal: invalid commit position. commit-graph is likely corrupt > > Since revision.c was the only user of the parse_commit_gently > compatibility define, remove it from commit.h. > > Signed-off-by: Michael Forney