From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sun, 08 Dec 2024 00:06:07 GMT
Subject: Re: [PATCH 1/3] git-submodule.sh: make some variables boolean
Message-ID: <CAPig+cS9tJ1YjGyCObmgrruv816szhzA57PJNBLghEiYj1Qs7A@mail.gmail.com>
In-Reply-To: <20241207135201.2536-2-royeldar0@gmail.com>

On Sat, Dec 7, 2024 at 8:53 AM Roy Eldar <royeldar0@gmail.com> wrote:
> When git-submodule.sh parses various options and switchs, it sets some

s/switchs/switches/

> variables to values; in particular, every switch that is passed causes a
> corresponding variable to be set to 1, which then affects the options
> given to git-submodule--helper.
>
> There are some variables are assigned "$1", although there is no reason

s/are assigned/assigned/

> for it; this was actually noticed in 757d092 for the "$cached" variable.
>
> Make some variables boolean, in order to increase consistency throught

s/throught/throughout/

> the script and reduce possible confusion.
>
> Signed-off-by: Roy Eldar <royeldar0@gmail.com>