From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mon, 05 Nov 2018 03:52:35 GMT
Subject: Re: [PATCH v2 2/5] pretty: allow showing specific trailers
Message-ID: <CAPig+cS8-7-6MzuUcTTPMOUBEGuJiPPui5hCECOAu7vDx0irLg@mail.gmail.com>
In-Reply-To: <xmqqa7mojibg.fsf@gitster-ct.c.googlers.com>

On Sun, Nov 4, 2018 at 10:48 PM Junio C Hamano <gitster@pobox.com> wrote:
> Eric Sunshine <sunshine@sunshineco.com> writes:
> > Does the user have to include the colon when specifying <val> of
> > 'key=<val>'?
> > Does 'key=<val>', do a full or partial match on trailers?
> > What happens if 'key=...' is specified multiple times?
> > Thinking further on the last two points, should <val> be a regular expression?
>
> Another thing that needs to be clarified in the document would be
> case sensitivity.  People sometimes spell "Signed-Off-By:" by
> mistake (or is it by malice?).

The documentation does say parenthetically "(matching is done
case-insensitively)", so I think that's already covered. Or did you
have something else in mind?