From: Eric Sunshine Date: Mon, 25 Feb 2019 20:08:05 GMT Subject: Re: [PATCH 1/3] Documentation/Makefile: add missing xsl dependencies for manpages Message-ID: In-Reply-To: On Mon, Feb 25, 2019 at 3:03 PM Martin Ågren wrote: > These stylesheets very rarely change, but when they do, it really helps > if the manpages depend on them. We're casting the net a bit too wide > here, since we'll only ever use a subset of the stylesheets, but since > these files change so rarely, that should be ok. It's better than > missing a dependency. > > Signed-off-by: Martin Ågren > --- > diff --git a/Documentation/Makefile b/Documentation/Makefile > @@ -354,7 +354,7 @@ $(OBSOLETE_HTML): %.html : %.txto asciidoc.conf > -%.1 %.5 %.7 : %.xml manpage-base-url.xsl > +%.1 %.5 %.7 : %.xml manpage-base-url.xsl $(wildcard manpage*.xsl) The wildcard expression also matches the manpage-base-url.xsl mentioned explicitly. Did you intentionally retain the explicit one or was that an oversight?