From: Eric Sunshine Date: Fri, 24 Apr 2015 21:51:41 GMT Subject: Re: [PATCH 4/5] ref_transaction_commit(): remove the local flags variables Message-ID: In-Reply-To: <1429875349-29736-5-git-send-email-mhagger@alum.mit.edu> On Fri, Apr 24, 2015 at 7:35 AM, Michael Haggerty wrote: > Instead, work directly with update->flags. This has the advantage that > the REF_DELETING bit, set in the first loop, can be read in the third > loop instead of having to compute the same expression again. Plus, it > was kindof confusing having both update->flags and flags, which s/kindof/kind of/ > sometimes had different values. > > Signed-off-by: Michael Haggerty