From: Eric Sunshine <sunshine@sunshineco.com>
Date: Wed, 17 Sep 2025 08:58:15 GMT
Subject: Re: [PATCH v2 12/18] build: new crate, build-helper
Message-ID: <CAPig+cS+=OVNBBZ6Yq7s_ihWjkDO02eMH14P1xny4qAeT9ynXQ@mail.gmail.com>
In-Reply-To: <1c923a71f27ba204ea17a725daf45576d0aa3ec5.1758071798.git.gitgitgadget@gmail.com>

On Tue, Sep 16, 2025 at 9:18 PM Ezekiel Newren via GitGitGadget
<gitgitgadget@gmail.com> wrote:
> Make a crate that takes care of the boiler-plate code that most
> build.rs files would need to write.
>
> Signed-off-by: Ezekiel Newren <ezekielnewren@gmail.com>
> ---
> diff --git a/.gitignore b/.gitignore
> @@ -257,3 +257,4 @@ Release/
>  .idea/
>  /rust/target/
>  /rust/Cargo.lock
> +

This seems to be adding an unnecessary blank line (for no apparent reason).

> diff --git a/rust/build-helper/Cargo.toml b/rust/build-helper/Cargo.toml
> @@ -0,0 +1,7 @@
> +[package]
> +name = "build-helper"
> +version = "0.1.0"
> +edition = "2021"
> +
> +[dependencies]
> +

I believe I saw a later patch make the sole change to this file of
removing the unnecessary blank line at the end of this file. It would
be better to fix this patch to omit the line in the first place.