From: Eric Sunshine <sunshine@sunshineco.com>
Date: Tue, 16 May 2023 02:53:31 GMT
Subject: Re: [PATCH 1/3] tests: do not negate test_path_exists
Message-ID: <CAPig+cRwPUJZdov7eAZbZ1qji9qj_Oh5RQ8bpLWsXW9J+QnvPA@mail.gmail.com>
In-Reply-To: <20230516022646.648123-2-gitster@pobox.com>

On Mon, May 15, 2023 at 10:37 PM Junio C Hamano <gitster@pobox.com> wrote:
> As a way to assert the path 'foo' is missing, "! test_path_exists foo" a
> poor way to do so, as the helper is designed to complain when 'foo' is
> missing, but the intention of the author who used negated form was to
> make sure it does not exist.  This does not help debugging the tests.

s/a poor/is &/

> Use test_path_is_missing instead, which is a more appropriate helper.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>