From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sun, 22 Mar 2015 20:19:01 GMT
Subject: Re: [PATCH 4/5] Add tests for git-log --merges=show|hide|only
Message-ID: <CAPig+cRvV2L3Wt3sMLHMngzeomLcD96Swfd3KSXJxnBEid2yVA@mail.gmail.com>
In-Reply-To: <550F1E9F.40801@web.de>

On Sun, Mar 22, 2015 at 3:57 PM, Torsten Bögershausen <tboegi@web.de> wrote:
> On 22.03.15 19:28, Koosha Khajehmoogahi wrote:
>> Signed-off-by: Koosha Khajehmoogahi <koosha@posteo.de>
>> ---
>> diff --git a/t/t4202-log.sh b/t/t4202-log.sh
>> index 5f2b290..ab6f371 100755
>> --- a/t/t4202-log.sh
>> +++ b/t/t4202-log.sh
>> @@ -428,6 +428,147 @@ cat > expect <<\EOF
>>  * initial
>>  EOF
>>
>> +cat > only_merges <<EOF
>
> - please no space after the ">"
> - please add the && at the end of the line:
> cat >only_merges <<EOF &&

This code is outside any test, so && has no impact (and would be
slightly confusing). Better would be to move this setup code into a
"setup --merges=" test, in which case the &&-chain would be
appropriate.