From: Eric Sunshine <sunshine@sunshineco.com>
Date: Tue, 17 Dec 2019 19:36:19 GMT
Subject: Re: [PATCH 08/15] t0020: s/test_must_fail has_cr/! has_cr/
Message-ID: <CAPig+cRupjwrfoccta1JyjuB1hNhVGOP=as+dDQ8BhUVcYX3nA@mail.gmail.com>
In-Reply-To: <8adc5cd5aaeef76ddeef459c79ecec7a05a1fd7b.1576583819.git.liu.denton@gmail.com>

On Tue, Dec 17, 2019 at 7:02 AM Denton Liu <liu.denton@gmail.com> wrote:
> t0020: s/test_must_fail has_cr/! has_cr/

Cryptic patch subject. How about being consistent with other patch
subjects in this series?

    t0020: don't use `test_must_fail has_cr`

> The test_must_fail function should only be used for git commands since
> we should assume that external commands work sanely. Since has_cr() just
> wraps a tr and grep pipeline, replace `test_must_fail has_cr` with
> `! has_cr`.
>
> Signed-off-by: Denton Liu <liu.denton@gmail.com>