From: Eric Sunshine Date: Thu, 02 Nov 2017 22:48:23 GMT Subject: Re: [PATCH v3 5/7] remote-mediawiki: support fetching from (Main) namespace Message-ID: In-Reply-To: <20171102212518.1601-6-anarcat@debian.org> On Thu, Nov 2, 2017 at 5:25 PM, Antoine Beaupré wrote: > When we specify a list of namespaces to fetch from, by default the MW > API will not fetch from the default namespace, refered to as "(Main)" > in the documentation: > > https://www.mediawiki.org/wiki/Manual:Namespace#Built-in_namespaces > > I haven't found a way to address that "(Main)" namespace when getting > the namespace ids: indeed, when listing namespaces, there is no > "canonical" field for the main namespace, although there is a "*" > field that is set to "" (empty). So in theory, we could specify the > empty namespace to get the main namespace, but that would make > specifying namespaces harder for the user: we would need to teach > users about the "empty" default namespace. It would also make the code > more complicated: we'd need to parse quotes in the configuration. > > So we simply override the query here and allow the user to specify > "(Main)" since that is the publicly documented name. > > Reviewed-by: Eric Sunshine As with the previous patch, it would be best to drop this Reviewed-by: since it has no value with my name attached to it and was not provided explicitly. > Signed-off-by: Antoine Beaupré