From: Eric Sunshine <sunshine@sunshineco.com>
Date: Fri, 18 Sep 2020 05:04:33 GMT
Subject: Re: [PATCH 1/2] ref-filter: refactor do_merge_filter()
Message-ID: <CAPig+cRso0DJm3KwYnBZZz7w2pJaWSd+gzfLsRfbrRqLNHAE-A@mail.gmail.com>
In-Reply-To: <CAPig+cRXJ5hCEM0dFsSSnGWaYu76gPhpM3fV4FaV+Db4r6dX4g@mail.gmail.com>

On Fri, Sep 18, 2020 at 1:03 AM Eric Sunshine <sunshine@sunshineco.com> wrote:
> > +       if (!check_reachable)
> >                 return;
>
> I would probably drop this conditional return altogether since it
> incorrectly conveys to the reader that it is legal to call this
> function with NULL for 'check_reachable', whereas, in reality, it
> would be pointless to do so. [...]

Nevermind. I'm an idiot. I forgot that filter->reachable_from and
filter->unreachable_from may indeed validly be NULL.