From: Eric Sunshine <sunshine@sunshineco.com>
Date: Wed, 05 Mar 2014 01:00:44 GMT
Subject: Re: [PATCH] disable grafts during fetch/push/bundle
Message-ID: <CAPig+cRqyG_JXSO-DsdP0mAjfmgS+FUCxLz+0+rHeUXrjmcjJg@mail.gmail.com>
In-Reply-To: <20140305003721.GA11509@sigill.intra.peff.net>

On Tue, Mar 4, 2014 at 7:37 PM, Jeff King <peff@peff.net> wrote:
> On Tue, Mar 04, 2014 at 06:36:07PM -0500, Eric Sunshine wrote:
>
>> On Tue, Mar 4, 2014 at 12:48 PM, Jeff King <peff@peff.net> wrote:
>> > diff --git a/commit.c b/commit.c
>> > index 6bf4fe0..886dbfe 100644
>> > --- a/commit.c
>> > +++ b/commit.c
>> > @@ -114,6 +114,11 @@ static unsigned long parse_commit_date(const char *buf, const char *tail)
>> >  static struct commit_graft **commit_graft;
>> >  static int commit_graft_alloc, commit_graft_nr;
>> >
>> > +int commit_grafts_loaded(void)
>> > +{
>> > +       return !!commit_graft_nr;
>> > +}
>>
>> Did you mean !!commit_graft ?
>
> Shouldn't they produce the same results?

Yes they should, but the use of !! seemed to imply that you wanted to
apply it to the pointer value. (If you indeed intended to use
commit_graft_nr, then 'return commit_graft_nr', without !!, would have
been sufficient and idiomatic C.)