From: Eric Sunshine <sunshine@sunshineco.com>
Date: Fri, 19 Apr 2013 00:27:45 GMT
Subject: Re: [PATCH v2 3/6] transport-helper: clarify pushing without refspecs
Message-ID: <CAPig+cRp7J+HYBA=2OL-CdA3NiQFjuUMZEjE+i+SnNrrPBAZ6Q@mail.gmail.com>
In-Reply-To: <1366258473-12841-4-git-send-email-felipe.contreras@gmail.com>

On Thu, Apr 18, 2013 at 12:14 AM, Felipe Contreras
<felipe.contreras@gmail.com> wrote:
> diff --git a/t/t5801-remote-helpers.sh b/t/t5801-remote-helpers.sh
> index cd1873c..3eeb309 100755
> --- a/t/t5801-remote-helpers.sh
> +++ b/t/t5801-remote-helpers.sh
> @@ -111,13 +111,13 @@ test_expect_success 'pulling without refspecs' '
>         compare_refs local2 HEAD server HEAD
>  '
>
> -test_expect_failure 'pushing without refspecs' '
> +test_expect_success 'pushing without refspecs' '
>         test_when_finished "(cd local2 && git reset --hard origin)" &&
>         (cd local2 &&
>         echo content >>file &&
>         git commit -a -m ten &&
> -       GIT_REMOTE_TESTGIT_REFSPEC="" git push) &&
> -       compare_refs local2 HEAD server HEAD
> +       GIT_REMOTE_TESTGIT_REFSPEC="" test_must_fail git push 2> ../error) &&
> +       grep "remote-helper doesn.t support push; refspec needed" error

Is "doesn.t" intentional? It certainly works by accident in grep, but
did you mean s/doesn.t/doesn't/ ?

>  '
>
>  test_expect_success 'pulling without marks' '