From: Eric Sunshine <sunshine@sunshineco.com>
Date: Tue, 24 Mar 2026 04:27:57 GMT
Subject: Re: [PATCH v2] t/pack-refs-tests: drop '-f' from test_path_is_missing
Message-ID: <CAPig+cRo6N-idg5ZEzsUyCZUzLoGNV5RR8PUxBb_RghoPXdXNQ@mail.gmail.com>
In-Reply-To: <20260324041903.43155-1-jayeshdaga99@gmail.com>

On Tue, Mar 24, 2026 at 12:22 AM jayesh0104 <jayeshdaga99@gmail.com> wrote:
> test_path_is_missing expects exactly one argument: the path to
> check for absence. Passing '-f' is incorrect and results in
> "bug in the test script: 1 param" during test execution.
>
> The '-f' flag appears to have been carried over from the
> equivalent 'test -f' usage, but test_path_is_missing does not
> accept such flags.
>
> Remove the extraneous '-f' to use the helper correctly and
> restore proper test behavior.

This commit message which talks about changing `test_path_is_missing
-f <path>` into `test_path_is_missing <path>`...

> Signed-off-by: Jayesh Daga <jayeshdaga99@gmail.com>
> ---
> diff --git a/t/pack-refs-tests.sh b/t/pack-refs-tests.sh
> @@ -61,7 +61,7 @@ test_expect_success 'see if a branch still exists after git ${pack_refs} --prune
>  test_expect_success 'see if git ${pack_refs} --prune remove ref files' '
>         git branch f &&
>         git ${pack_refs} --all --prune &&
> -       ! test -f .git/refs/heads/f
> +       test_path_is_missing .git/refs/heads/f
>  '

...does not reflect the code change at all.