From: Eric Sunshine <sunshine@sunshineco.com>
Date: Thu, 27 Feb 2014 06:59:03 GMT
Subject: Re: [PATCH v3 21/25] checkout: support checking out into a new working directory
Message-ID: <CAPig+cRnAm1fz0u2UHEWeZvERbwgOsSe=m3wWLMVvmjzUnRarg@mail.gmail.com>
In-Reply-To: <CACsJy8BkAOk4d3nFP_CtUN4Feer0sHy8H8vpbUWcZcYMLYgYyg@mail.gmail.com>

On Wed, Feb 26, 2014 at 6:19 PM, Duy Nguyen <pclouds@gmail.com> wrote:
> On Thu, Feb 27, 2014 at 3:06 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
>>> +       len = strlen(path);
>>> +       if (!len || is_dir_sep(path[len - 1]))
>>> +               die(_("'--to' argument '%s' cannot end with a slash"), path);
>>
>> What is the purpose of this restriction?
>
> Laziness on my part :) Because the following loop searches backward to
> get the `basename $path`, trailing slash would make it return empty
> base name. I could have just removed the trailing slash here instead
> of dying though. Thanks for catching.

Thanks for the explanation. I thought that that might be the case.

>>> +       for (name = path + len - 1; name > path; name--)
>>> +               if (is_dir_sep(*name)) {
>>> +                       name++;
>>> +                       break;
>>> +               }