From: Eric Sunshine <sunshine@sunshineco.com>
Date: Wed, 18 May 2016 03:33:29 GMT
Subject: Re: [PATCH v2 3/5] t1500: avoid changing working directory outside of tests
Message-ID: <CAPig+cRn9fjo6CB9p7fKio=Nav-2WRjiUSkWiM3rqdO-4aREBA@mail.gmail.com>
In-Reply-To: <20160518010609.Horde.sM8QUFek6WMAAwho56DDob8@webmail.informatik.kit.edu>

On Tue, May 17, 2016 at 7:06 PM, SZEDER Gábor <szeder@ira.uka.de> wrote:
> Quoting Junio C Hamano <gitster@pobox.com>:
>> Jeff King <peff@peff.net> writes:
>>> On Tue, May 17, 2016 at 04:48:33PM -0400, Eric Sunshine wrote:
>>>> On Tue, May 17, 2016 at 4:37 PM, Junio C Hamano <gitster@pobox.com>
>>>> wrote:
>>>>> Eric Sunshine <sunshine@sunshineco.com> writes:
>>>>>> +                     git ${dir:+-C "$dir"} rev-parse --$o >actual &&
>>>>>
>>>>> This is kosher POSIX, but I vaguely recall some shells had trouble
>>>>> with the SP between -C and "$dir" in the past.  Let's see if anybody
>>>>> screams; hopefully I am misremembering or buggy shells died out.
>>>>
>>>> I also am bothered by a vague recollection of some issue (possibly
>>>> involving the internal space and lack of quotes around the entire
>>>> ${...}), but couldn't remember nor find a reference to the specific
>>>> details. Perhaps someone reading the patch has a better memory than I.
>>>
>>> Probably:
>>>  http://thread.gmane.org/gmane.comp.version-control.git/265094
>
> And ea10b60c910e (Work around ash "alternate value" expansion bug,
> 2009-04-18) as well.
>
>    http://thread.gmane.org/gmane.comp.version-control.git/116816

Thanks for the additional link. I have v3 ready to roll and will send
it out within the next day if no more actionable review comments
arrive.