From: Eric Sunshine <sunshine@sunshineco.com>
Date: Thu, 20 Oct 2022 16:37:48 GMT
Subject: Re: [PATCH v2 00/12] fsmonitor: Implement fsmonitor for Linux
Message-ID: <CAPig+cRkQLyy8X7y=1jhrVwYERk5ucagAfJkTAOPNODofiZr1g@mail.gmail.com>
In-Reply-To: <xmqq8rlamq29.fsf@gitster.g>

On Thu, Oct 20, 2022 at 12:13 PM Junio C Hamano <gitster@pobox.com> wrote:
> So here is my "panda-see-panda-do" attempt.
>
> ----- >8 --------- >8 --------- >8 --------- >8 --------- >8 -----
> Subject: [PATCH] ci: use DC_SHA1=1 on osx-clang job for CI
>
> All other jobs were using the default DC_SHA1 (which is a
> recommended practice), but the default for macOS jobs being Apple's
> common crypt, we didn't catch recent breakage soon enough.

"recent breakage" is quite vague and probably won't help future
readers understand what this is actually fixing. Possible
improvements: (1) a prose description of the breakage; (2) the actual
compiler error message; (3) a pointer[1] to the email reporting the
problem. One or more of the above improvements to the commit message
would help future readers.

[1]: https://lore.kernel.org/git/kl6l7d0yyu6r.fsf@chooglen-macbookpro.roam.corp.google.com/

> We may want to give similar diversity for Linux jobs so that some of
> them build with other implementations of SHA-1, but let's start
> small and fill only the immediate need.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
> diff --git a/ci/lib.sh b/ci/lib.sh
> index 1b0cc2b57d..5a115704cb 100755
> --- a/ci/lib.sh
> +++ b/ci/lib.sh
> @@ -259,6 +259,8 @@ macos-latest)
>                 MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=$(which python3)"
>         else
>                 MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=$(which python2)"
> +               MAKEFLAGS="$MAKEFLAGS NO_APPLE_COMMON_CRYPTO=NoThanks"
> +               MAKEFLAGS="$MAKEFLAGS DC_SHA1=1 NO_OPENSSL=1"
>         fi
>         ;;
>  esac