From: Eric Sunshine Date: Wed, 19 Oct 2022 02:28:14 GMT Subject: Re: [PATCH v2 00/12] fsmonitor: Implement fsmonitor for Linux Message-ID: In-Reply-To: <221019.86bkq8hake.gmgdl@evledraar.gmail.com> On Tue, Oct 18, 2022 at 9:22 PM Ævar Arnfjörð Bjarmason wrote: > On Tue, Oct 18 2022, Glen Choo wrote: > > I'm not too familiar with the CI, but I took a quick peek at ci/lib.sh > > and noticed that none of the jobs build with sha1dc, not even the Linux > > or Windows ones, so.. > > All of our jobs except the OSX one build with SHA1_DC, because it's the > default. > > Per my just-sent > https://lore.kernel.org/git/cover-v2-0.4-00000000000-20221019T010222Z-avarab@gmail.com/ > the blind spot has been lack fo SHA1_DC on OSX, for others it's the > reverse, we don't test e.g. BLK_SHA1. > > In practice we've been catching SHA-implementation specific code early > because the OSX implementation was different, but in this case it's > OSX-only code, so it only supported the Apple Common Crypto backend. I don't know how germane it is to the current thread, but previous discussions[1,2,3,4] favored dropping use of Apple's Common Crypto altogether since it doesn't seem to buy us much (or anything) and is incomplete; it doesn't support all of the OpenSSL API Git uses. [1]: https://lore.kernel.org/git/CAPig+cTfMx_kwUAxBRHp6kNSOtXsdsv=odUQSRYVpV21DnRuvA@mail.gmail.com/ [2]: https://lore.kernel.org/git/CAMYxyaVQyVRQb-b0nVv412tMZ3rEnOfUPRakg2dEREg5_Ba5Ag@mail.gmail.com/T/ [3]: https://lore.kernel.org/git/20160102234923.GA14424@gmail.com/ [4]: https://lore.kernel.org/git/CAPig+cQ5kKAt2_RQnqT7Rn=uGmHV9VvxpQ+UgDPOj=D=pq6arg@mail.gmail.com/