From: Eric Sunshine <sunshine@sunshineco.com>
Date: Tue, 19 Jan 2016 17:56:18 GMT
Subject: Re: [PATCH v4 2/2] interpret-trailers: add option for in-place editing
Message-ID: <CAPig+cRi2knygjeaMtojAr65BE71B-z7q+s8V5rcGrV9Qja6jw@mail.gmail.com>
In-Reply-To: <xmqqio2pbgov.fsf@gitster.mtv.corp.google.com>

On Tue, Jan 19, 2016 at 12:52 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Eric Sunshine <sunshine@sunshineco.com> writes:
>> I think POSIXPERM is all you need for this case; SANITY doesn't buy
>> you anything, if I understand correctly.
>>
>>>> +     cat basic_message >message &&
>>>> +     chmod -r message &&
>>>> +     test_must_fail git interpret-trailers --trailer "Reviewed-by: Alice" --in-place message &&
>
> The purpose of "chmod -r message" is to force interpret-trailers to
> fail due to its input being unreadable; without SANITY, i.e. running
> this test as root, the command would happily read from message that
> is marked as unreadable by anybody, and test_must_fail will not pass.

Makes sense. I never run tests as root, thus wasn't thinking along those lines.