From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sat, 28 Jul 2018 06:27:55 GMT
Subject: Re: [PATCH 2/8] t3206: add color test for range-diff --dual-color
Message-ID: <CAPig+cRgfeSTFLdGpUkzH5PuKE39W9CFxx--yarF_27q1c=yCw@mail.gmail.com>
In-Reply-To: <20180728030448.192177-3-sbeller@google.com>

On Fri, Jul 27, 2018 at 11:05 PM Stefan Beller <sbeller@google.com> wrote:
> The 'expect'ed outcome is taken by running the 'range-diff |decode';
> it is not meant as guidance, rather as a documentation of the current
> situation.

I'm not really sure what this is trying to say. It seems _too_ brief.

Did you want a space after the vertical bar before "decode"?

> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
> diff --git a/t/t3206-range-diff.sh b/t/t3206-range-diff.sh
> +test_expect_success 'simple coloring' '
> +       q_to_tab >expect <<-EOF &&

Why 'q_to_tab'? I don't see any "q"'s in the body.

I also don't see any variable interpolation in the body, so maybe you
want -\EOF instead?