From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sat, 17 Aug 2024 07:33:06 GMT
Subject: Re: [PATCH 2/5] pack-bitmap: load writer config from repository parameter
Message-ID: <CAPig+cRgJkXxESSL4h+LO5FKcxKf6pt5VBWpjfUAZrrB5b0Kww@mail.gmail.com>
In-Reply-To: <20240817072653.GB1535915@coredump.intra.peff.net>

On Sat, Aug 17, 2024 at 3:27 AM Jeff King <peff@peff.net> wrote:
> In bitmap_writer_init(), we take a repository parameter but ever look at

s/ever/never/

> it. Most of the initialization here is independent of the repository,
> but we do load some config. So let's pass the repo we get down to
> load_pseudo_merges_from_config(), which in turn can use repo_config(),
> rather than depending on the_repository via git_config().
>
> The outcome is the same, since all callers pass in the_repository
> anyway. But it takes us a step closer to getting rid of the global, and
> as a bonus it silences an unused parameter warning.
>
> Signed-off-by: Jeff King <peff@peff.net>