From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sun, 22 Jul 2018 05:04:20 GMT
Subject: Re: [PATCH v4 11/21] range-diff: add tests
Message-ID: <CAPig+cRd2V_hN0BVCcevXhu1v_QpL76mhqTGQmWPLK7sAD4Ytw@mail.gmail.com>
In-Reply-To: <2b8d09020fff0ac220c1878c65b47290c5245cb9.1532210683.git.gitgitgadget@gmail.com>

On Sat, Jul 21, 2018 at 6:05 PM Thomas Rast via GitGitGadget
<gitgitgadget@gmail.com> wrote:
> These are essentially lifted from https://github.com/trast/tbdiff, with
> light touch-ups to account for the command now being names `git

s/names/named/

> range-diff`.
>
> Apart from renaming `tbdiff` to `range-diff`, only one test case needed
> to be adjusted: 11 - 'changed message'.
>
> The underlying reason it had to be adjusted is that diff generation is
> sometimes ambiguous. In this case, a comment line and an empty line are
> added, but it is ambiguous whether they were added after the existing
> empty line, or whether an empty line and the comment line are added
> *before* the existing empty line. And apparently xdiff picks a different
> option here than Python's difflib.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>