From: Eric Sunshine <sunshine@sunshineco.com>
Date: Wed, 24 Mar 2021 19:23:30 GMT
Subject: Re: [PATCH v8 04/37] hook: include hookdir hook in list
Message-ID: <CAPig+cRcWUgM=c9k-P1hGZGJEZpSgHXK=_ribJeLVsiQWV3LnQ@mail.gmail.com>
In-Reply-To: <xmqq1rc4z7ry.fsf@gitster.g>

On Wed, Mar 24, 2021 at 3:12 PM Junio C Hamano <gitster@pobox.com> wrote:
> Not just we do not want "hookdir" placed inside _(),
>
>                         printf("%s: %s\n",
> +                              (item->from_hookdir
> +                               ? "hookdir"
> +                               : config_scope_name(item->origin)),
>                                item->command.buf);
>
> we do not want the "%s: %s\n" to be placed inside _() and get munged
> into "%2$s: %1$s\n" for languages that want the order swapped, for
> example.
>
> So perhaps the comment should be about the entire output, i.e.
> "don't translate the output from this helper, as it is meant to be
> machine parseable", or something?

Having the word "translate" in the comment automatically implies
localization, which confuses the issue. It would be clearer to avoid
that word altogether. Perhaps something along the lines of:

    /* machine-parseable output; do not apply _() localization */