From: Eric Sunshine Date: Mon, 05 Apr 2021 17:31:42 GMT Subject: Re: [PATCH 2/5] test-lib: use exact match for test_subcommand Message-ID: In-Reply-To: <2b74889c2a323f03be477ffdf9ff388405779c3b.1617627856.git.gitgitgadget@gmail.com> On Mon, Apr 5, 2021 at 9:04 AM Derrick Stolee via GitGitGadget wrote: > The use of 'grep' inside test_subcommand uses general patterns, leading > to sometimes needing escape characters to avoid incorrect matches. > Further, some platforms interpret different glob characters differently. These are regular expression metacharacters, not glob characters. A more general way to say this might be: Furthermore, it can be difficult to know which characters need escaping since the actual regular expression language implemented by various `grep`s differs between platforms; for instance, some may employ pure BRE, whereas others a mix of BRE & ERE. Sidestep this difficulty by using `grep -F`... > Use 'grep -F' to use an exact match. This requires removing escape > characters from existing callers. Luckily, this is only one test that > expects refspecs as part of the subcommand. > > Reported-by: Eric Sunshine > Signed-off-by: Derrick Stolee The Reported-by: feels a bit unusual in this context. Perhaps Helped-by: would be more appropriate. > diff --git a/t/t7900-maintenance.sh b/t/t7900-maintenance.sh > @@ -142,8 +142,8 @@ test_expect_success 'prefetch multiple remotes' ' > - test_subcommand git fetch remote1 $fetchargs +refs/heads/\\*:refs/prefetch/remote1/\\* - test_subcommand git fetch remote2 $fetchargs +refs/heads/\\*:refs/prefetch/remote2/\\* + test_subcommand git fetch remote1 $fetchargs +refs/heads/*:refs/prefetch/remote1/* + test_subcommand git fetch remote2 $fetchargs +refs/heads/*:refs/prefetch/remote2/*