From: Eric Sunshine <sunshine@sunshineco.com>
Date: Wed, 24 Feb 2016 00:55:53 GMT
Subject: Re: [PATCH 1/3] t3034: add rename threshold tests
Message-ID: <CAPig+cR_p2aKU9VRpiyomdOo+Ucnxr82dh2uqBaR6TTsN9B4qw@mail.gmail.com>
In-Reply-To: <CAPig+cQ+MF7Nsvp7jASXPtPjNWT_g865ot45Y1Q347Y1iCDeYA@mail.gmail.com>

On Tue, Feb 23, 2016 at 7:50 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Tue, Feb 23, 2016 at 6:48 PM, Felipe Gonçalves Assis
> <felipeg.assis@gmail.com> wrote:
>> +       if [ 50 -le "$th0" ]; then
>> +               check_50=check_threshold_0
>> +       elif [ 50 -le "$th1" ]; then
>> +               check_50=check_threshold_1
>> +       elif [ 50 -le "$th2" ]; then
>> +               check_50=check_threshold_2
>> +       fi &&

Oh, I totally forgot to mention a few style issues:

1. use 'test' rather than '['
2. place 'then' on its own line
3. drop semicolon

    if test 50 -le "$th0"
    then
        ...
    elif test ...
    then
        ...