From: Eric Sunshine <sunshine@sunshineco.com>
Date: Fri, 06 Aug 2021 20:01:32 GMT
Subject: Re: [RFC PATCH v3 3/4] advice: remove use of global advice_add_embedded_repo
Message-ID: <CAPig+cR_GGjnP-h-tNnyd5nFXr1=S-BUWAYc4VgpUBHvxiZW=g@mail.gmail.com>
In-Reply-To: <RFC-patch-v3-3.4-02613d0f30-20210806T191231Z-avarab@gmail.com>

On Fri, Aug 6, 2021 at 3:13 PM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
> The external use of this variable was added in 532139940c9 (add: warn
> when adding an embedded repository, 2017-06-14), for the use-case it's

s/, for/. For/

> more straightforward to track whether we've adviced in

s/adviced/advised/
...or better...
s/we've adviced/we've shown advice/

> check_embedded_repo() than setting the global variable.
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>