From: Eric Sunshine <sunshine@sunshineco.com>
Date: Thu, 30 Aug 2018 20:34:43 GMT
Subject: Re: [PATCH] doc/Makefile: remove tmp-doc-diff on "make clean"
Message-ID: <CAPig+cRXEegGwm3QiyEZqkVN1NYv5xAAYRuAKHUE8n-g9m6jqw@mail.gmail.com>
In-Reply-To: <20180830195546.GA22407@sigill.intra.peff.net>

On Thu, Aug 30, 2018 at 3:55 PM Jeff King <peff@peff.net> wrote:
> The tmp-doc-diff directory isn't strictly a build product of
> the Makefile, since it's only present if you manually run
> the doc-diff script.  But anybody running "make clean" would
> probably want it to go away.
>
> Suggested-by: Eric Sunshine <sunshine@sunshineco.com>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> diff --git a/Documentation/Makefile b/Documentation/Makefile
> @@ -332,6 +332,7 @@ clean:
>         $(RM) manpage-base-url.xsl
> +       $(RM) -r tmp-doc-diff

Taking into consideration that people might be surprised and alarmed
to find "git worktree list" showing a worktree they didn't explicitly
create, would it make sense to do something like this?

clean:
    ...
    -git worktree remove -f tmp-doc-diff 2>/dev/null
    $(RM) -r tmp-doc-diff