From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mon, 24 Feb 2020 22:11:11 GMT
Subject: Re: [PATCH v4 2/3] advice: revamp advise API
Message-ID: <CAPig+cRWEnQL2Pye=20M0cjHsAFPvLVFWpOv_JM-Gm0hXZUS7w@mail.gmail.com>
In-Reply-To: <xmqqftezod3n.fsf@gitster-ct.c.googlers.com>

On Mon, Feb 24, 2020 at 5:05 PM Junio C Hamano <gitster@pobox.com> wrote:
> "Heba Waly via GitGitGadget" <gitgitgadget@gmail.com> writes:
> > +test_expect_success 'advise should be printed when config variable is unset' '
> > +     test-tool advise "This is a piece of advice" 2>actual &&
> > +     test_i18ncmp expected actual
> > +'
>
>  - Prepare the expected output inside test_expect_success block that
>    uses it.
>  - There should be no SP between a redirection operator and the
>    filename.
>  - Here-doc that does not use parameter expansion should use a
>    quoted EOF marker.
>  - The file that gets compared with "actual" is by convention called
>    "expect", not "expected".
>
> test_expect_success 'advise should be printed when config variable is unset' '

Also, s/advise/advice/ in the test title.

>         cat >expect <<-\EOF &&
>         hint: ...
>         hint: ...
>         EOF
>         test-tool advise "This is a piece of advice" 2>actual &&
>         test_i18ncmp expected actual
> '

s/expected/expect/