From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mon, 05 Feb 2024 22:00:28 GMT
Subject: Re: [PATCH 2/4] notes: use exisisting function stream_blob_to_fd
Message-ID: <CAPig+cRVqnp8YTeDvxuM12B_bt7OoJJZc9_v=KtG_By0NJ9ZMA@mail.gmail.com>
In-Reply-To: <20240205204932.16653-3-maarten.bosmans@vortech.nl>

On Mon, Feb 5, 2024 at 4:53 PM Maarten Bosmans <mkbosmans@gmail.com> wrote:
> notes: use exisisting function stream_blob_to_fd

s/exisisting/existing/

> Use functionality from streaming.c and remove the copy_obj_to_fd()
> function local to notes.c.
>
> Streaming the blob to stdout instead of copying through an
> intermediate buffer might also be more efficient, but at the
> size a typical note is, this is unlikely to matter a lot.
>
> Signed-off-by: Maarten Bosmans <maarten.bosmans@vortech.nl>