From: Eric Sunshine Date: Sat, 20 Sep 2025 05:10:50 GMT Subject: Re: [PATCH 3/6] revision: add wrapper to setup_revisions() from a strvec Message-ID: In-Reply-To: <20250919224847.GC594545@coredump.intra.peff.net> On Fri, Sep 19, 2025 at 6:51 PM Jeff King wrote: > The setup_revisions() function was designed to take the argc/argv pair > from the operating system. But we sometimes construct our own argv using > a strvec and pass that in. There are a few gotchas that callers need to > deal with here: > [...] > We'll start by converting all of the call-sites which the > free_removed_argv_elements option. There should be no behavior change > for them, except that their "shrunken" entries are cleaned up > immediately, rather than waiting for a strvec_clear() call. There is some grammatical problem with the first sentence of this paragraph which makes it difficult to decipher. > Signed-off-by: Jeff King