From: Eric Sunshine <sunshine@sunshineco.com>
Date: Tue, 03 Sep 2013 19:03:14 GMT
Subject: Re: [PATCH v3] peel_onion(): add support for <rev>^{tag}
Message-ID: <CAPig+cRQP5CGz_1ckf5Qr6HcB+OvWHNPtGQ8RxWdqTZK0fRo2w@mail.gmail.com>
In-Reply-To: <1378229853-21236-1-git-send-email-rhansen@bbn.com>

On Tue, Sep 3, 2013 at 1:37 PM, Richard Hansen <rhansen@bbn.com> wrote:
> diff --git a/t/t1511-rev-parse-caret.sh b/t/t1511-rev-parse-caret.sh
> index eaefc77..5771cbd 100755
> --- a/t/t1511-rev-parse-caret.sh
> +++ b/t/t1511-rev-parse-caret.sh
> @@ -54,6 +61,26 @@ test_expect_success 'ref^{tree}' '
>         test_must_fail git rev-parse blob-tag^{tree}
>  '
>
> +test_expect_success 'ref^{tag}' '
> +       echo $BLOB_TAG_SHA1 >expected &&
> +       git rev-parse --verify blob-tag^{tag} >actual &&
> +       test_cmp expected actual &&
> +       echo $TREE_TAG_SHA1 >expected &&
> +       git rev-parse --verify tree-tag^{tag} >actual &&
> +       test_cmp expected actual &&
> +       echo $COMMIT_TAG_SHA1 >expected &&
> +       git rev-parse --verify commit-tag^{tag} >actual &&
> +       test_cmp expected actual &&
> +       echo $TAG_TAG_SHA1 >expected &&
> +       git rev-parse --verify tag-tag^{tag} >actual &&
> +       test_cmp expected actual &&
> +       test_must_fail git rev-parse --verify $BLOB_SHA1^{tag} &&
> +       test_must_fail git rev-parse --verify $TREE_SHA1^{tag} &&
> +       test_must_fail git rev-parse --verify $COMMIT_SHA1^{tag} &&
> +       test_must_fail git rev-parse --verify rev^{tag} &&
> +       true
> +'

The unnecessary trailing "&& true" is unusual. Such form is not used
elsewhere in this file, or in any script in the test suite.

> +
>  test_expect_success 'ref^{/.}' '
>         git rev-parse master >expected &&
>         git rev-parse master^{/.} >actual &&
> --
> 1.8.4