From: Eric Sunshine <sunshine@sunshineco.com>
Date: Thu, 04 Feb 2021 00:14:50 GMT
Subject: Re: [PATCH v4 6/9] rebase -i: add fixup [-C | -c] command
Message-ID: <CAPig+cROYr0H80ZosNUQe_mxVaRtwgqirtNxFPr2a8tnenvwwQ@mail.gmail.com>
In-Reply-To: <CAPSFM5fLi-U3zVcXFip_kgchHSXiEUF9nngO2nSf31kAEBkq1w@mail.gmail.com>

On Wed, Feb 3, 2021 at 7:01 PM Charvi Mendiratta <charvi077@gmail.com> wrote:
> > > I admit it resulted in a bit of confusion. Here, its true that flag is always
> > > going to be specific enum item( as command can be merge -c, fixup -c, or
> > > fixup -C ) and I combined the bag of bits to denote
> > > the specific enum item. So, maybe we can go with the first method?
> >
> > Sounds fine. It would clarify the intent.
>
> (Apology for confusion) After, looking again at the source code, as we are using
> the flag element of  the structure todo_item of in sequencer.h. So, I
> think right
> way is to let it be in binary only and change type from 'enum todo_item_flag' to
> 'unsigned' , as you suggested below (better than first method) :

That would be fine, as well. Thanks.