From: Eric Sunshine <sunshine@sunshineco.com>
Date: Thu, 07 Mar 2024 21:26:36 GMT
Subject: Re: [PATCH] wt-status: Don't find scissors line beyond buf len
Message-ID: <CAPig+cRNa22A=fEmc__JvEjYiVF-QG8o7w0gukhbeL3e-PwVkA@mail.gmail.com>
In-Reply-To: <xmqqo7bpka6e.fsf@gitster.g>

On Thu, Mar 7, 2024 at 4:24 PM Junio C Hamano <gitster@pobox.com> wrote:
> "Kristoffer Haugsbakk" <code@khaugsbakk.name> writes:
> > On Thu, Mar 7, 2024, at 21:47, Junio C Hamano wrote:
> >> [jc: tweaked the commit log message and the implementation a bit]
> >
> > Just a question. Given the imperative mood principle/rule, why are these
> > bracket changelog lines always written in the past tense?
>
> These are not giving orders to the code to become like so.  The
> trailer block records what happend to the patch in chronological
> order---think of those written there at one level higher level,
> "meta" comments.

Also, they are not always written in past tense[*].

[*]: https://lore.kernel.org/git/20240112171910.11131-1-ericsunshine@charter.net/