From: Eric Sunshine <sunshine@sunshineco.com>
Date: Fri, 26 Feb 2016 02:26:14 GMT
Subject: Re: [PATCH v3 2/2] git: submodule honor -c credential.* from command line
Message-ID: <CAPig+cRM_1JLfBiOqo+-EdKbXp--4VUbddKN_zpSCSLK8PT09w@mail.gmail.com>
In-Reply-To: <CA+P7+xqyTUh60BOmY03JHE6HyVqY7iidVkUf3ji95_s3uE32cg@mail.gmail.com>

On Thu, Feb 25, 2016 at 9:19 PM, Jacob Keller <jacob.keller@gmail.com> wrote:
> On Thu, Feb 25, 2016 at 5:55 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:
>> Not worth a re-roll, but these quote sequences are brain-melting.
>> Easier would have been to double-quote the second argument of
>> test_expect_success() and then do either:
>
> They are. I fiddled with things till I got it working. I wasn't sure
> if double quotes would cause a problem or not, since most other tests
> seemed to avoid it.

You normally want variable interpolations within the test to happen
when the test is actually run rather than when it is defined, which is
why single quotes are normally used. But this test doesn't use any
variable interpolations, so double quotes won't hurt it.

> However this re-roll forgot to check argc in submodule--helper so
> maybe worth reroll to fix both things?

Possibly.

One thing I elided accidentally was that when changing the second
argument of test_expect_success to double-quotes, you would altogether
drop the double-quotes around "helper" in:

    git -c credential.helper="helper" submodule--helper [...] &&

to become:

    git -c credential.helper=helper submodule--helper [...] &&