From: Eric Sunshine <sunshine@sunshineco.com>
Date: Tue, 24 Oct 2017 16:19:26 GMT
Subject: Re: [PATCH 1/2] t1404: add a bunch of tests of D/F conflicts
Message-ID: <CAPig+cRLB=dGD=+Af=yYL3M709LRpeUrtvcDLo9iBKYy2HAW-w@mail.gmail.com>
In-Reply-To: <be088bd57e61f4ea0dc974a65829a928ecd30534.1508856679.git.mhagger@alum.mit.edu>

On Tue, Oct 24, 2017 at 11:16 AM, Michael Haggerty <mhagger@alum.mit.edu> wrote:
> diff --git a/t/t1404-update-ref-errors.sh b/t/t1404-update-ref-errors.sh
> @@ -34,6 +34,86 @@ test_update_rejected () {
> +# Test adding and deleting D/F-conflicting references in a single
> +# transaction.
> +df_test() {
> +       local prefix="$1"
> +       shift
> +       local pack=:

Isn't "local" a Bash-ism we want to keep out of the test scripts?

> +       local symadd=false
> +       local symdel=false
> +       local add_del=false
> +       local addref
> +       local delref
> +       while test $# -gt 0
> +       do