From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sun, 09 Jun 2013 07:18:04 GMT
Subject: Re: [PATCH 1/2] core: use env variable instead of config var to turn on logging pack access
Message-ID: <CAPig+cRK+mcPXpsUZSQH1hHx3E2Aq+S_44rV0sytLnGBHh+1xg@mail.gmail.com>
In-Reply-To: <1370755369-30868-1-git-send-email-pclouds@gmail.com>

On Sun, Jun 9, 2013 at 1:22 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
> 5f44324 (core: log offset pack data accesses happened - 2011-07-06)
> provides a way to observe pack access patterns via a config
> switch. Setting an environment variable looks more obvious than a
> config var, especially when you just need to _observe_, and more
> inline with other tracing knobs we have.

s/inline/in line/ (IMHO)

Or: "..., and akin to other tracing knobs we have."

> Document it as it may be useful for remote troubleshooting.
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>