From: Eric Sunshine <sunshine@sunshineco.com>
Date: Tue, 07 Jan 2020 12:50:41 GMT
Subject: Re: Assertion in git log graphing [regression in v2.25]
Message-ID: <CAPig+cRH-yeHmeikf=cbTTMDom+7SLtT2dmya=WP7fsy8tTY3g@mail.gmail.com>
In-Reply-To: <fe1cd838-d390-96ab-d3b4-72df5aa61947@gmail.com>

On Tue, Jan 7, 2020 at 7:42 AM Derrick Stolee <stolee@gmail.com> wrote:
> Here is a a patch that reproduces the test failure. It hits the
> assert, so it definitely fails.

What happens if someone builds the project with NDEBUG? Then the test
won't fail as expected. Perhaps this patch ought to also change those
asserts() to `if (...) BUG(...)` to ensure consistent behavior.