From: Eric Sunshine <sunshine@sunshineco.com>
Date: Fri, 19 Oct 2018 14:10:36 GMT
Subject: Re: [PATCH] send-email: explicitly disable authentication
Message-ID: <CAPig+cRFZ3kvbrUJpQheSFTvdah0Pds8boF0vf-p94SeWoUE+g@mail.gmail.com>
In-Reply-To: <9dc2995ff84158450255478c7411339a81f63aba.camel@gmail.com>

On Thu, Oct 18, 2018 at 6:02 PM Joshua Watt <jpewhacker@gmail.com> wrote:
> On Thu, 2018-10-18 at 17:53 -0400, Eric Sunshine wrote:
> > On Thu, Oct 18, 2018 at 5:16 PM Joshua Watt <jpewhacker@gmail.com>
> > wrote:
> > Implementation complexity aside, spelling the option --no-smtp-auth
> > might be more intuitive and consistent than --smtp-auth=none.
>
> One advantage of --smtp-auth=none is that it can also be done with a
> config variable sendemail.smtpauth="none". Would be also add a config
> variable like sendemail.nosmtpauth (the negative seems strange to me)?

I would not expect to see a "negating" config variable like that. I
was just suggesting that a "--no-*" command-line option might be more
intuitive.

> Or maybe --no-smtp-auth is just a shorthand alias for --smtp-auth=none?

That's one possibility.