From: Eric Sunshine Date: Tue, 05 May 2020 05:52:23 GMT Subject: Re: [PATCH] builtin/receive-pack: avoid generic function name hmac Message-ID: In-Reply-To: <20200505054630.5821-1-carenas@gmail.com> On Tue, May 5, 2020 at 1:46 AM Carlo Marcelo Arenas Belón wrote: > [...] > While the conflict, posses the question of why are we even implementing our > own RFC 2104 complaint HMAC while alternatives are readily available, the > simplest solution is to make sure the name is not as generic so it would > conflict with an equivalent one from the system (or linked libraries); so > rename it again to hmac_hash to reflect it will use the git's defined hash > function. > --- Missing sign-off.