From: Eric Sunshine <sunshine@sunshineco.com>
Date: Fri, 15 May 2015 21:41:05 GMT
Subject: Re: [PATCH v7 4/5] command-list.txt: drop the common tag
Message-ID: <CAPig+cRDq7VaBL-KHn4OcNaYW_KbYCH074GkbuCqm=grGadmvQ@mail.gmail.com>
In-Reply-To: <1431714904-16599-5-git-send-email-sebastien.guimmara@gmail.com>

On Fri, May 15, 2015 at 2:35 PM, Sébastien Guimmara
<sebastien.guimmara@gmail.com> wrote:
> The parser generate-cmdlist.awk gathers all group information without
> needing the common tag.

This might leave the reader wondering why the "common" tag was there
in the first place. I probably would have written it this way:

    command-list.sh, retired in the previous patch, was the only
    consumer of the "common" tag, so drop this now-unnecessary
    attribute.

> before:
>     git-add          mainporcelain        common worktree
>
> after:
>     git-add          mainporcelain        worktree

which makes this example effectively unnecessary (plus, the patch
itself already says the same thing).

> Helped-by: Eric Sunshine <sunshine@sunshineco.com>
> Signed-off-by: Sébastien Guimmara <sebastien.guimmara@gmail.com>
> ---
> diff --git a/command-list.txt b/command-list.txt
> index c00b0b6..2203566 100644
> --- a/command-list.txt
> +++ b/command-list.txt
> @@ -11,30 +11,30 @@ remote       collaborate (see also: git help workflows)
>  # List of known git commands.
>  # command name                          category [deprecated] [common]
>  [commands]
> -git-add                                 mainporcelain           common worktree
> +git-add                                 mainporcelain           worktree