From: Eric Sunshine Date: Wed, 17 Sep 2025 09:16:48 GMT Subject: Re: [PATCH v2 16/18] build: new crate, misc Message-ID: In-Reply-To: <17143ced6feea5927b66c0578f1c2fbb07378504.1758071798.git.gitgitgadget@gmail.com> On Tue, Sep 16, 2025 at 9:18 PM Ezekiel Newren via GitGitGadget wrote: > build: new crate, misc > > Signed-off-by: Ezekiel Newren > --- Please extend the commit message to at least give _some_ information about what the "misc" crate is all about since it is not at all apparent based upon the name. By the way, is "misc" really a good name? It sounds like it's going to be a dumping ground for anything which doesn't fit anywhere else. > diff --git a/rust/misc/Cargo.toml b/rust/misc/Cargo.toml > @@ -0,0 +1,14 @@ > +[lib] > +name = "misc" > +path = "src/lib.rs" > +## staticlib to generate xdiff.a for use by gcc > +## cdylib (optional) to generate xdiff.so for use by gcc > +## rlib is required by the rust unit tests > +crate-type = ["staticlib", "rlib"] > + > +[dependencies] > diff --git a/rust/misc/src/lib.rs b/rust/misc/src/lib.rs > new file mode 100644 > index 0000000000..e69de29bb2 Do I understand correctly from the comment that this crate has something to do with "xdiff", yet there doesn't actually seem to be anything here referencing "xdiff"? Am I missing something?