From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sun, 03 Jun 2018 08:16:06 GMT
Subject: Re: [PATCH 19/22] sequencer.c: mark more strings for translation
Message-ID: <CAPig+cRCJbZxaO6vmt+8D7aOLZDGrDVDMB97zfRAfwmtRPP_Zg@mail.gmail.com>
In-Reply-To: <20180602043241.9941-20-pclouds@gmail.com>

On Sat, Jun 2, 2018 at 12:32 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
> diff --git a/sequencer.c b/sequencer.c
> @@ -2597,15 +2597,17 @@ static int error_with_patch(struct commit *commit,
> -               fprintf(stderr, "You can amend the commit now, with\n"
> -                       "\n"
> -                       "  git commit --amend %s\n"
> -                       "\n"
> -                       "Once you are satisfied with your changes, run\n"
> -                       "\n"
> -                       "  git rebase --continue\n", gpg_sign_opt_quoted(opts));
> +               fprintf(stderr,
> +                       _("You can amend the commit now, with\n"
> +                         "\n"
> +                         "  git commit --amend %s\n"
> +                         "\n"
> +                         "Once you are satisfied with your changes, run\n"
> +                         "\n"
> +                         "  git rebase --continue\n"),
> +                       gpg_sign_opt_quoted(opts));
>         } else if (exit_code)
> -               fprintf(stderr, "Could not apply %s... %.*s\n",
> +               fprintf_ln(stderr, _("Could not apply %s... %.*s"),

Did you want to downcase "Could" for consistency with other error
messages, or was this left as-is intentionally?