From: Eric Sunshine <sunshine@sunshineco.com>
Date: Thu, 17 Oct 2019 23:26:30 GMT
Subject: Re: [PATCH 04/12] t5520: replace test -f with test_path_is_file
Message-ID: <CAPig+cRBA-guwHN-bhRvgbzc52YU-e_ipSQ7BYqDV6yNnvXmTA@mail.gmail.com>
In-Reply-To: <f3cb583110f508b4a421326ea6667280e848930d.1571354136.git.liu.denton@gmail.com>

On Thu, Oct 17, 2019 at 7:17 PM Denton Liu <liu.denton@gmail.com> wrote:
> Although `test -f` has the same functionality as test_path_is_file(), in
> the case where test_path_is_file() fails, we get much better debugging
> information. Replace `test -f` with test_path_is_file so that future
> developers will have a better experience debugging these test cases.
>
> Signed-off-by: Denton Liu <liu.denton@gmail.com>
> ---
> diff --git a/t/t5520-pull.sh b/t/t5520-pull.sh
> @@ -99,7 +99,7 @@ test_expect_success 'pulling into void must not create an octopus' '
>         (
>                 cd cloned-octopus &&
>                 test_must_fail git pull .. master master &&
> -               ! test -f file
> +               test_must_fail test_path_is_file file
>         )

According to t/README, this is not a valid use of test_must_fail(),
which is reserved for detecting failure of Git commands. Either use
'!' as the original code did, or perhaps use test_path_is_missing().