From: Eric Sunshine <sunshine@sunshineco.com>
Date: Tue, 28 Apr 2020 16:09:50 GMT
Subject: Re: [PATCH v4 2/4] git-credential-store: skip empty lines and comments from store
Message-ID: <CAPig+cR8YGGXLcdiv1SHF5wQ305RgG1S0JhheVgF9fYstKxaQA@mail.gmail.com>
In-Reply-To: <20200428105254.28658-2-carenas@gmail.com>

On Tue, Apr 28, 2020 at 6:53 AM Carlo Marcelo Arenas Belón
<carenas@gmail.com> wrote:
> git-credential-store: skip empty lines and comments from store

I don't see anything in this patch which makes it skip anything at
all; it only introduces a new test.

> with the added checks for invalid URLs in credentials, any locally
> modified store files which might have empty lines or even comments
> were reported[1] failing to parse as valid credentials.
>
> add corresponding failing cases
>
> [1] https://stackoverflow.com/a/61420852/5005936
>
> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>