From: Eric Sunshine Date: Fri, 21 Jul 2023 18:34:18 GMT Subject: Re: [PATCH 0/5] commit-graph: test cleanup and modernization Message-ID: In-Reply-To: On Fri, Jul 21, 2023 at 1:31 PM Taylor Blau wrote: > This short series addresses a few style nitpicks that I noticed while > looking through the commit-graph tests while writing [1]. > > Most importantly, it removes many instances in t5318 that change > directories outside of a sub-shell, altering the current working > directory of subsequent tests. This makes it difficult to run a subset > of tests, or otherwise include `cd "$TRASH_DIRECTORY"` at the top of > each test. > > The first two patches are predatory, the next two are the substantive > test clean-ups, and the final patch cleans up some intermediate state > necessary to perform the clean-up over multiple commits. Nice to see this being cleaned up. I had tackled this script, as well, back in November 2022 as part of an unsubmitted patch series which removes _all_ unprotected `cd` commands from all test scripts. t5318 was one of several particularly egregious cases.