From: Eric Sunshine <sunshine@sunshineco.com>
Date: Wed, 27 Sep 2023 23:20:27 GMT
Subject: Re: [PATCH 02/30] oid-array: Teach oid-array to handle multiple kinds of oids
Message-ID: <CAPig+cR5mGZ7-4t1YBW-=j3FyWGvBRBN7eogQb1BYiw8QM1UKA@mail.gmail.com>
In-Reply-To: <20230927195537.1682-2-ebiederm@gmail.com>

On Wed, Sep 27, 2023 at 3:55 PM Eric W. Biederman <ebiederm@gmail.com> wrote:
> While looking at how to handle input of both SHA-1 and SHA-256 oids in
> get_oid_with_context, I realized that the oid_array in
> repo_for_each_abbrev might have more than one kind of oid stored in it
> simulataneously.

s/simulataneously/simultaneously/

> Update to oid_array_append to ensure that oids added to an oid array
> always have an algorithm set.
>
> Update void_hashcmp to first verify two oids use the same hash algorithm
> before comparing them to each other.
>
> With that oid-array should be safe to use with differnt kinds of
> oids simultaneously.

s/differnt/different/

> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>