From: Eric Sunshine Date: Sun, 26 Nov 2023 17:49:13 GMT Subject: Re: [PATCH] i18n: factorize even more 'incompatible options' messages Message-ID: In-Reply-To: On Sun, Nov 26, 2023 at 6:57 AM René Scharfe wrote: > Continue the work of 12909b6b8a (i18n: turn "options are incompatible" > into "cannot be used together", 2022-01-05) and a699367bb8 (i18n: > factorize more 'incompatible options' messages, 2022-01-31) to use the > same parameterized error message for reporting incompatible command line > options. This reduces the number of strings to translate and makes the > UI slightly more consistent. Thanks for tackling this. A couple additional instances recently slipped into `show-ref.c` which were caught during review[1,2] but nevertheless made it to "master"[3,4]. This patch, of course, doesn't need to address those, but if rerolling for some other reason, perhaps they can be included, as well(?). [1]: https://lore.kernel.org/git/CAPig+cSrp7vZuy7D_ENHKZKZzF4OSmCtfYNHPGMtS1Hj6gArDw@mail.gmail.com/ [2]: https://lore.kernel.org/git/CAPig+cRTOMie0rUf=Mhbo9e2EXf-_2kQyMeqpB9OCRB1MZZ1rw@mail.gmail.com/ [3]: 199970e72f (builtin/show-ref: ensure mutual exclusiveness of subcommands, 2023-10-31) [4]: 9080a7f178 (builtin/show-ref: add new mode to check for reference existence, 2023-10-31)